Add 'column-{allow/deny}-list' optional inputs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `column-allow-list` and `column-deny-list` optional inputs. If neither is set the behavior of the action is identical to before. `column-allow-list` may be set to a string or list of strings (separated by comma or newline character) which specifes columns that the action may move cards from only. That is, if `column-deny-list` is set to `todo,wip` then only cards in `todo` and `wip` can be moved by the job. If unset all cards in all columns may be moved (assuming `column-deny-list` is also unset). `column-deny-list` may also be set to a string or list of strings (again, separated by a comma or newline character) which specifies columns that the action may never move cards. That is, if `column-deny-list` is set to `todo,wip` then cards in `todo` and `wip` will not be moved by the job. If unset all the cards in all the columns may be moved (assuming `column-allow-list` is also unset). from. This addresses: alex-page#41. Tests have been added to verify previous behavior is preserved and these new inputs function as intended.
BobbyRBruce
force-pushed
the
add-deny-allow-columns
branch
from
73eb198 to
f1c2861
Compare
BobbyRBruce
commented
Aug 23, 2023
Comment on lines
+19
to
+21
| }, | ||
| column: { | ||
| name: 'Hotbox' |
There was a problem hiding this comment.
I could use some help here. I am unsure of this is correct. I've been running on the assumption the data is laid out like this. It shouldn't be too hard to change if it's different. Essentially I just need to be able to get the column the card is currently in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
column-allow-listandcolumn-deny-listoptionalinputs. If neither is set the behavior of the action is identical to
before.
column-allow-listmay be set to a string or list of strings(separated by comma or newline character) which specifes columns that
the action may move cards from only. That is, if
column-deny-listisset to
todo,wipthen only cards intodoandwipcan be moved bythe job. If unset all cards in all columns may be moved (assuming
column-deny-listis also unset).column-deny-listmay also be set to a string or list of strings(again, separated by a comma or newline character) which specifies
columns that the action may never move cards. That is, if
column-deny-listis set totodo,wipthen cards intodoandwipwill not be moved by the job. If unset all the cards in all the columns
may be moved (assuming
column-allow-listis also unset).from.
This addresses:
#41.
Tests have been added to verify previous behavior is preserved and
these new inputs function as intended.