Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

fix: hide shadow catcher on non shadow render #157

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

OlliePugh
Copy link
Collaborator

Copy link
Owner

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it, but seems good 👍


14. Then modify the output resolution to match the ratio of the subject (dont forget about the shadow!).

15. You may also need to change the _Orthographic Scale_ on the _Camera's Lens_ data property. (This will change how zoomed in the camera is).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot find a link to the data tab in the blender docs.


14. Then modify the output resolution to match the ratio of the subject (dont forget about the shadow!).

15. You may also need to change the _Orthographic Scale_ on the _Camera's Lens_ data property. (This will change how zoomed in the camera is).
Copy link
Owner

@alestiago alestiago Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "may"? In which cases would we don't do so? Only those where it is already Orthographic? If so, maybe we want: "Ensure that"

Copy link
Collaborator Author

@OlliePugh OlliePugh Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camera might already be the correct level of zoom, on smaller items it is, (depends how Samantha has setup the camera)

The camera will already be orthographic, but the scale may not be correct.

@OlliePugh
Copy link
Collaborator Author

need to validate this still works and I didnt mess up the rebase

@alestiago
Copy link
Owner

alestiago commented Feb 19, 2024

Is this only a documentation change now?

@OlliePugh
Copy link
Collaborator Author

Is this only a documentation change now?

A didnt realise the result of the rebase was just a empty line removal. So yeah this is just a docs piece now, oops.

@OlliePugh OlliePugh merged commit 025b7ac into main Feb 19, 2024
1 check passed
@OlliePugh OlliePugh deleted the olliepugh/fix-transparent-render branch February 19, 2024 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants