Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic integration test for aleph dev command #410

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Add basic integration test for aleph dev command #410

merged 1 commit into from
Oct 9, 2021

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Oct 2, 2021 •
edited
Loading

This PR tries to add basic integration test for the aleph dev command.

Summary / Background

  • Added integration_test.ts and basic test case for the aleph dev command
    • deno-dom module is used to query rendered elements.
  • This change is intended to improve maintainability and detect bugs quickly
  • There is a problem that a zombie process remains alive after running integration_test.ts 😢 (Zombie subprocesses  denoland/deno#7087)

@uki00a uki00a requested a review from ije as a code owner October 2, 2021 09:47
@ije
Copy link
Member

ije commented Oct 9, 2021

lgtm, thanks @uki00a

@ije ije merged commit 06f7a1a into alephjs:master Oct 9, 2021
@uki00a uki00a deleted the add-basic-integration-test-to-aleph-dev branch October 9, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ije ije Awaiting requested review from ije

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uki00a @ije