Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet V2 #86

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Testnet V2 #86

merged 3 commits into from
Oct 17, 2023

Conversation

h0ngcha0
Copy link
Member

Update Guardian addresses and relevant URLs

@h0ngcha0 h0ngcha0 requested a review from Lbqds October 16, 2023 07:16
Copy link
Member

@Lbqds Lbqds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lbqds
Copy link
Member

Lbqds commented Oct 16, 2023

One more remark: we also need to redeploy the contract with the new guardian set and update the configs.

},
network_id: "5",
gas: 4465030,
gasPrice: 10000000000,
gasPrice: 1000000000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be too expensive for mainnet deployment later?

Copy link
Member

@Lbqds Lbqds Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for goerli, different network uses different gasPrice config, we need to update the gasPrice for mainnet when we deploy contracts on the mainnet:

gasPrice: 191000000000,

@h0ngcha0 h0ngcha0 merged commit 78e0c33 into master Oct 17, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants