Remove the alphMinConfirmations flag
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Aug 31, 2023
| @@ -144,7 +144,7 @@ func (w *Watcher) getGovernanceEventsByTxId( | |||
|
|
|||
| reobservedEvents = append(reobservedEvents, &reobservedEvent{ | |||
| &event, | |||
| maxUint8(msg.consistencyLevel, w.minConfirmations), | |||
| msg.consistencyLevel, | |||
There was a problem hiding this comment.
Not related to this PR: how do we enforce the minimum consistencyLevel for new messages from users?
There was a problem hiding this comment.
Currently, we enforce the minimum consistency level in both frontend and contract:
- The frontend sets the
consistencyLevelto 105 when the user sends a transaction - We also check in the contract that the
consistencyLevelfor the transfer transaction is not less than 105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalTokenPoolon AlephiumI will release 0.1.0 after this PR is merged.