Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay the original token logo and symbol for bridged tokens #147

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Nov 5, 2024

The source chain is Alephium and the target chain is Ethereum:
Screenshot 2024-11-06 at 20 37 56

The source chain is Alephium and the target chain is BSC
Screenshot 2024-11-06 at 20 38 03

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment.

@@ -55,14 +87,15 @@ export async function getEthereumToken(
}

export async function ethTokenToParsedTokenAccount(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] evmTokenToParsedTokenAccount

@polarker
Copy link
Member

polarker commented Nov 6, 2024

Q: Should we filter the tokens based on the network connected? E.g. If I am connected to Ethereum, then only eth tokens should be selectable

@Lbqds
Copy link
Member Author

Lbqds commented Nov 6, 2024

Q: Should we filter the tokens based on the network connected? E.g. If I am connected to Ethereum, then only eth tokens should be selectable

Sounds great 👍, will update

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lbqds Lbqds merged commit 957412a into master Nov 6, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants