-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay the original token logo and symbol for bridged tokens #147
Conversation
2dffd54
to
f44b022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one minor comment.
bridge_ui/src/utils/evm.ts
Outdated
@@ -55,14 +87,15 @@ export async function getEthereumToken( | |||
} | |||
|
|||
export async function ethTokenToParsedTokenAccount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nit] evmTokenToParsedTokenAccount
Q: Should we filter the tokens based on the network connected? E.g. If I am connected to Ethereum, then only eth tokens should be selectable |
Sounds great 👍, will update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The source chain is Alephium and the target chain is Ethereum:
The source chain is Alephium and the target chain is BSC