Announce the injected provider #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lbqds
commented
Nov 18, 2024
| @@ -116,12 +116,6 @@ export const alephiumWindowObject: AlephiumWindowObject = | |||
| throw Error("User aborted") | |||
| } | |||
|
|
|||
| const { alephiumProviders } = window | |||
There was a problem hiding this comment.
Since window.alephiumProviders.alephium may be undefined, and we will detect injected providers in the dApp, we need to remove the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
window.alephiumProvidersis set by different wallets, when both the onekey extension wallet and the alephium extension wallet are enabled at the same time,window.alephiumProviders.alephiumbecomesundefined(possibly because in the onekey,window.alephiumProvidersis set to non-configurable, and in the alephium wallet,window.alephiumProviders.alephiumis set to non-writable). This PR adopts the EIP6963 approach to make it easier for dApps to detect injected providers.