Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network Management #215

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Update Network Management #215

merged 4 commits into from
Sep 25, 2024

Conversation

h0ngcha0
Copy link
Member

  1. Make it possible to update URLs for Mainnet (already possible to Testnet and Devnet)
  2. Make it not possible to add extra custom networks. The reason is that it makes things complicated: a) custom network can not be connected with dApps which require one of the devnet, testnet or mainnet network. b) tokens in token list belong to one of testnet or mainnet. Due to these, custom network feature is probably not used that much.
  3. Make it possible to use nodeAPIKey
  4. Remove temporary fix for displaying 000301 NFT since explorer backend 2.2.1 is now used.

There is already a button to reset to default network if user messes up the network settings.

@polarker
Copy link
Member

@h0ngcha0 Could you add screenshots to this so I could review it without running the code?

@h0ngcha0
Copy link
Member Author

Yes, please see the images below:

image
image
image

Copy link

@pragmaxim pragmaxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍

@polarker
Copy link
Member

@h0ngcha0 It seems the reset icon is not aligned with the text next to it

@h0ngcha0
Copy link
Member Author

@h0ngcha0 It seems the reset icon is not aligned with the text next to it

Thanks, fixed now

image

Copy link
Member

@Lbqds Lbqds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@polarker
Copy link
Member

LGTM. Let's release

@polarker polarker merged commit 3234610 into master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants