Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up i18n and integrate extension to Crowdin #198

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Jun 14, 2024

This is the scaffolding work for:

  1. Setting up i18next and react-i18next to the extension wallet
  2. Extracting strings
  3. Integrating the extension wallet to Crowdin

Related to #197

Now, what needs to be done, is to wrap all strings with either the t function (from the useTranslation hook) or the i18n.t function (if we are not inside a React component/hook) and list those strings in the /locales/en-US/translation.json file. The rest will be take care from the Crowdin interface.

@nop33 nop33 requested a review from h0ngcha0 June 14, 2024 14:07
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@h0ngcha0 h0ngcha0 merged commit 86e7e46 into master Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants