Navigate to Accounts Page when No Account is Available #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Apr 20, 2024
| @@ -280,7 +280,8 @@ export const ApproveTransactionScreen: FC<ApproveTransactionScreenProps> = ({ | |||
| }, [selectedAccount, buildResult, onSubmit, onReject, navigate]) | |||
|
|
|||
| if (!selectedAccount) { | |||
| throw Error(`No account found for network ${networkId}`) | |||
| rejectAction(actionHash) | |||
| return <Navigate to={routes.accounts()} /> | |||
There was a problem hiding this comment.
Why clicking the reset button would trigger this component?
There was a problem hiding this comment.
I can't reproduce at all with the reset button, even when resetting while we are on this particular component.
Does it end up in this component every time you click the reset button?
There was a problem hiding this comment.
This is what clicking reset button shows for me, after clicking reset, it goes back to the welcome screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to reject the current action before going to the accounts page, otherwise it will end up in a loop, causing black screen.
See discussion here.