Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Optional NFT Royalties #34

Merged
merged 34 commits into from
Sep 6, 2023
Merged

Support Optional NFT Royalties #34

merged 34 commits into from
Sep 6, 2023

Conversation

h0ngcha0
Copy link
Member

Support Optional NFT Royalties

@h0ngcha0
Add INFTCollectionWithRoyalty
2bb0316
@h0ngcha0
Restructure the source code
83211ca
@h0ngcha0
Implement simple royalty
3518146
@h0ngcha0
Add basic logic for Royalty
a717e5a
@h0ngcha0
Remove collectionId from NFTListing; Fix tests
ade603f
@h0ngcha0
Improve nft-collection.test.ts
7114f27
@h0ngcha0
Restructure tests
06a546d
@h0ngcha0
Test nft open collection with royalty
28082aa
@h0ngcha0
Improve nft-public-sale-collection-random.test.ts
d22d0d7
@h0ngcha0
Improve nft-public-sale-collection-sequential.test.ts
3865be1
@h0ngcha0
Test royalty for random public sales collection
7cb8ba1
@h0ngcha0
Test royalty for sequential public sales collection
34194a3
@h0ngcha0
Restructure NFTCollectionHelper
d64191e
@h0ngcha0
Test open collection with royalty in marketplace
64ecf69
@h0ngcha0
Test royalty for open collection in marketplace
348db11
@h0ngcha0
Test royalty for public sale open collection in marketplace
52cc295
@h0ngcha0
Test royalty for public sale seqential collection in marketplace
20451de
@h0ngcha0
Support optional royalty in UI
f225025
@h0ngcha0 h0ngcha0 changed the title Optional NFT Royalties Support Optional NFT Royalties Aug 21, 2023
@h0ngcha0 h0ngcha0 requested a review from Lbqds August 22, 2023 12:12
@h0ngcha0 h0ngcha0 changed the base branch from buyer-pay-listing-fee to master August 24, 2023 14:35
polarker
polarker reviewed Aug 24, 2023
View reviewed changes
.project.json Outdated Show resolved Hide resolved
polarker
polarker reviewed Aug 28, 2023
View reviewed changes
contracts/marketplace/nft_marketplace_utils.ral Outdated Show resolved Hide resolved
contracts/nft/nft.ral Outdated Show resolved Hide resolved
@polarker
Copy link
Member

The core contracts LGTM. I will leave the rest to you guys.

@h0ngcha0 h0ngcha0 merged commit 1920375 into master Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lbqds Lbqds Lbqds left review comments

@polarker polarker polarker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h0ngcha0 @polarker @Lbqds