Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to suport SQLAlchemy 2.0 migration #82

Merged
merged 6 commits into from
Apr 25, 2023
Merged

refactor to suport SQLAlchemy 2.0 migration #82

merged 6 commits into from
Apr 25, 2023

Conversation

catileptic
Copy link
Contributor

No description provided.

@catileptic catileptic marked this pull request as draft April 12, 2023 14:01
@catileptic catileptic marked this pull request as ready for review April 19, 2023 14:05
stchris
stchris reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM and I much appreciate the effort! Left a few minor comments.

.github/workflows/build.yml Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@catileptic catileptic merged commit e35a185 into main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stchris stchris stchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catileptic @stchris