Add a task to Redis if it is no longer tracked after NACKing #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catileptic
commented
Jun 18, 2024
| @@ -319,7 +319,6 @@ def mark_for_retry(self, task): | |||
| f" for retry after NACK" | |||
| ) | |||
|
|
|||
| pipe.sadd(make_key(stage_key, "pending"), task.task_id) | |||
There was a problem hiding this comment.
Removing this since we are calling add_task if a task is no longer being tracked by Redis and it is about to be NACK'ed. add_task already increases the number of pending tasks, so this is no longer needed.
catileptic
commented
Jun 18, 2024
| "task_id": "test-task", | ||
| "job_id": "test-job", |
There was a problem hiding this comment.
just changed the order to match the order of args in Task()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.