Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for Avalanche Account #86

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Add provider for Avalanche Account #86

merged 4 commits into from
Nov 21, 2022

Conversation

Rgascoin
Copy link
Member

Add metamask support and tests
related issue: #60

@Rgascoin Rgascoin added the enhancement New feature or request label Oct 18, 2022
@Rgascoin Rgascoin self-assigned this Oct 18, 2022
@Rgascoin Rgascoin requested a review from BjrInt October 18, 2022 14:16
Solution: Add metamask support and tests
@Rgascoin Rgascoin force-pushed the Feat/provider/avalanche branch from e6e7b41 to 7d25754 Compare October 18, 2022 15:31
Copy link
Member

@BjrInt BjrInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got to ensure that the instanciated address is indeed a C-Chain AVAX address

Solution: Change the ChainType when you are using Avax from a web3 provider
@Rgascoin Rgascoin requested a review from BjrInt October 24, 2022 11:42
Solution: Call the RPC provider to switch to the specified network
@Rgascoin Rgascoin force-pushed the Feat/provider/avalanche branch from 93918f8 to e42a883 Compare October 24, 2022 15:07
Copy link
Member

@BjrInt BjrInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjrInt BjrInt merged commit 76a9570 into main Nov 21, 2022
@BjrInt BjrInt deleted the Feat/provider/avalanche branch November 21, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants