Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: websocket for GetMessages #122

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Feat: websocket for GetMessages #122

merged 5 commits into from
Jan 3, 2024

Conversation

Rgascoin
Copy link
Member

@Rgascoin Rgascoin commented Feb 20, 2023

Feat: user can't retrieve data from Aleph through webSocket
Solution: Add a websocket implementation

  • WebSocket handled
  • Toolshed test
  • NodeSocket handled

Solution: Add a websocket implementation
@Rgascoin Rgascoin self-assigned this Feb 20, 2023
@Rgascoin Rgascoin force-pushed the Feat/Any/Websocket branch 2 times, most recently from d839058 to d129851 Compare February 21, 2023 16:48
@Rgascoin Rgascoin requested a review from BjrInt March 13, 2023 13:57
@Rgascoin Rgascoin marked this pull request as ready for review March 13, 2023 13:57
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code duplication, but not worrysome as I intend to refactor the whole thing anyways. Works and LGTM 👍

@MHHukiewitz MHHukiewitz merged commit 69198aa into main Jan 3, 2024
@MHHukiewitz MHHukiewitz deleted the Feat/Any/Websocket branch January 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants