Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large constant or rom variables are no more working #239

Open
alekmaul opened this issue Aug 23, 2023 · 2 comments
Open

Large constant or rom variables are no more working #239

alekmaul opened this issue Aug 23, 2023 · 2 comments

Comments

@alekmaul
Copy link
Owner

alekmaul commented Aug 23, 2023

we have an issue with last version of pvsneslib, big constants are no more working as it seems the .db part is no more handling more than 256 characters or something like that.
you can reproduce it with helloworld example, try to do that: unsigned int stuff[2048]={0};
it will not compile with a Unknown symbol "$0";
perhaps it is the now 816opt who is not doing the job, but it worked with 4.0.2 version of pvsneslib.
@kobenairb , any idea where we can investigate about this issue?

@kobenairb
Copy link
Contributor

Hi @alekmaul,

It's probably my last updates on tcc. I take a look today to find the problem.

@kobenairb
Copy link
Contributor

kobenairb commented Aug 23, 2023

I found the problem, it's about 816-opt with #define MAXLEN_LINE 10240. It's too small to handle the long .db $0?... line. I remember that we already mate it before. A quick and dirty fix is to extend MAXLEN_LINE to 102400. I will try to modify the optimizer to use malloc and realloc to dynamically extend it.

kobenairb added a commit to kobenairb/pvsneslib that referenced this issue Aug 23, 2023
RetroAntho added a commit that referenced this issue Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants