Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Reviewer annotation is misleading when Declined (or just Optional?) #167

Open
kentyman23 opened this issue Jul 21, 2021 · 0 comments
Open

Comments

@kentyman23
Copy link
Contributor

When I have Declined a review, it's a little misleading to see a red Last Reviewer annotation. I'm not considered in the list of reviewers blocking a PR, so I'm not really the last reviewer. Perhaps this annotation should be left off when Declined.

image

It's less clear to me how to handle mere Optional reviewers. They're not blocking, but they're still people considered in the list of reviewers. I think my preference is to exclude all Optional reviewers, whether Declined or not, as the red Last Reviewer annotation seems intended to prevent PRs from being blocked.

kentyman23 added a commit to kentyman23/azdo-userscripts that referenced this issue Nov 6, 2023
Only show the Last Reviewer pill for Required PRs that have not been Declined. This assumes Azure DevOps Services REST API 6.0 or later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant