-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multibranch pipelines #55
base: master
Are you sure you want to change the base?
Support for multibranch pipelines #55
Conversation
Hi @jitbasemartin , First of all, thank you for your PR 👍 I don't use multibranch, neither know it works, so it's great to see someone contributing to this. Since you said to be your first PR on GitHub, I would recommend you the same thing I was recommended on my first PR. Don't change coding standard/format on your PRs. I guess it wasn't intentional, but I noted a few changes which just do that, so I would ask you to revert those changes and push an update to the PR. I will try to take a look at this next week. Thank you |
Hello @alefragnani |
Hi @jitbasemartin , Yes, exactly the white space stuff. Take a look on the differences in I use ESLint too, and the rules are defined inside "eslintConfig": {
"extends": [
"vscode-ext"
]
}, In the end, it is basically the recommended rules for ESLint and TypeScript, with minor tweaks. extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
],
rules: {
"@typescript-eslint/explicit-module-boundary-types": 0,
"@typescript-eslint/no-unused-vars": 1,
"@typescript-eslint/no-explicit-any": 1,
"@typescript-eslint/no-non-null-assertion": 1,
"eqeqeq": 2
} But it appears more than just ESLint, like a formatter. Are you using Prettier or something similar? |
Hello,
I add the feature mentioned in #16. I use it on my vscode
PS: Be nice, it's my first PR on Github