Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmark navigation commands to the editor context menu #154

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Add bookmark navigation commands to the editor context menu #154

merged 1 commit into from
Nov 17, 2018

Conversation

miqh
Copy link
Contributor

@miqh miqh commented Oct 6, 2018

Hello,

A fairly trivial change that should address #150.

@alefragnani
Copy link
Owner

Hi @miqh

Thank you for your PR 👍 . I should merge it next week, when I come back from vacation ..

@alefragnani
Copy link
Owner

Hi @miqh ,

I'm finally coming back to this 😄

I made just one small change. I changed the order that the context menu items appears. I put them below the Toggle command. I felt the Toggle should be the main command and confirmed that Sublime and Notepad++ follow this model as well.

I should release an update this weekend.

Thanks again for your PR 👍

@alefragnani alefragnani merged commit 5af69d4 into alefragnani:master Nov 17, 2018
@miqh miqh deleted the feat/editor-context-navigation branch November 17, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants