Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Bookmarks are lost when a file is renamed #529

Closed
alefragnani opened this issue Apr 3, 2022 · 0 comments · Fixed by #530
Closed

[BUG] - Bookmarks are lost when a file is renamed #529

alefragnani opened this issue Apr 3, 2022 · 0 comments · Fixed by #530
Assignees
@alefragnani
Labels
bug
Milestone
April 2022

Comments

@alefragnani
Copy link
Owner

Environment/version

  • Extension version: 13.2.4
  • VSCode version: 1.66
  • OS version: MacOS Big Sur

Steps to reproduce

  1. Add bookmarks to some file
  2. Rename that file via VS Code Explorer
  3. Bookmarks are vanished
  4. Rename the file back to the original name
  5. Bookmarks are restored

Regression of #209, probably caused by #230
@alefragnani alefragnani added the bug label Apr 3, 2022
@alefragnani alefragnani added this to the March 2022 milestone Apr 3, 2022
@alefragnani alefragnani self-assigned this Apr 3, 2022
alefragnani added a commit that referenced this issue Apr 3, 2022
@alefragnani
Fix regression of rename files (Closes #529)
a9c6c78
@alefragnani alefragnani mentioned this issue Apr 3, 2022
Merged
alefragnani added a commit that referenced this issue Apr 4, 2022
@alefragnani
Merge pull request #530 from alefragnani/fix/rename-files-regression
097333f 
Fix regression of rename files (Closes #529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alefragnani alefragnani

Labels
bug
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

Fix regression of rename files (Closes #529) alefragnani/vscode-bookmarks
1 participant
@alefragnani