Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Toggling bookmarks in notebook cells results in a duplicate editor being opened #456

Closed
DonJayamanne opened this issue Jul 22, 2021 · 2 comments
Labels
Milestone

Comments

@DonJayamanne
Copy link

Environment/version

  • Extension version:13.1.0
  • VSCode version: 1.59.0-insider (VS Code Insiders)
  • OS version: Mac

Steps to reproduce

  1. Install Jupyter extension or other extension that support notebooks
  2. Create a notebook file *.ipynb
  3. Add some code into a cell and toggle bookmarks
  4. Notice how a duplicate editor is opened for the code cell.

Thanks for this great extension. I would have submitted a PR to resolve this, however it seems the code used to add bookmarks is closed source (or its just me being silly as I was unable to find the code)

recording

@alefragnani
Copy link
Owner

Hi @DonJayamanne ,

I don’t use Notebooks that much, but I think I know what’s causing that. If that’s the case, it should be fixed in the next release.

Thanks for reporting

@alefragnani alefragnani added this to the June 2021 milestone Jul 24, 2021
@alefragnani
Copy link
Owner

When I first saw your issue, I was wondering if #294 could be closed, but then I installed the .NET Interactive Notebook extension, and could see the extension is not working properly, unfortunately.

Even if the Bookmark can be added to the line, and being able to navigate between bookmarks on the same file, the List from All Files command and the Side Bar does not work. Mostly because the bookmarks are tied to the file (.ipynb) itself, not each Cell. So, Notebook support must be properly handled.

But, specifically about your issue, I just noticed it has been fixed while working on #440. So, it won't duplicate the editor anymore on the next release.

Hope this helps.

sthagen pushed a commit to sthagen/alefragnani-vscode-bookmarks that referenced this issue Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants