Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show line numbers for bookmarks in the Side Bar #321

Closed
cateyes99 opened this issue Jul 8, 2020 · 7 comments
Closed

Show line numbers for bookmarks in the Side Bar #321

cateyes99 opened this issue Jul 8, 2020 · 7 comments
Labels

Comments

@cateyes99
Copy link

Currently in the Side Bar's Bookmarks Explorer, no line numbers are shown for bookmarks. It'd be more informative & convenient to have the line number shown in front of each bookmark.

@alefragnani
Copy link
Owner

Hi @cateyes99 ,

The Side Bar shows both, line and column number, for each bookmarked line.

It is displayed as a detail on each line, following the line content/bookmark label.

Icon + LineContent/BookmarkLabel + (Ln X, Col Y)

Screen Shot 2020-07-09 at 17 16 55

Hope this helps

@cateyes99
Copy link
Author

ic. It turned out that if the length of the line bookmarked is very long then the line & column info has not room to display which is not good. For instance, in your screenshot, the bookmark in the CHANGELOG.md file doesn't show the line & column info. 🙄

@cateyes99
Copy link
Author

i would say it's a bug then. @alefragnani

@alefragnani
Copy link
Owner

It turned out that if the length of the line bookmarked is very long then the line & column info has not room to display which is not good

That’s how VS Code works. The same happens on other native views, like the Search view, when you search for text. It displays the file path as a detail, but if the file name is long and the panel is not wide enough to, you won’t see the file path.

I understand it’s not that good, but if you think it is a bug, I would say it’s a VS Code bug. You should report that on VS Code repo

Hope this helps

@cateyes99
Copy link
Author

hmm. if it's a limitation from VSCode, what about placing the line number info at the beginning instead of at the end then?

@alefragnani
Copy link
Owner

Because I think the line contents/bookmark label are more important than its position.

But, there is however, issue #145, which requests "customizable line". So, it would allows each developer decides the info it finds more importantly be seen.

Feel free to upvote/comment if you think it would fit your scenario.

Hope this helps

@cateyes99
Copy link
Author

cateyes99 commented Jul 13, 2020

If there are many bookmarks in a file, I'd say the line info is helpful & very convenient (the column info isn't though). But i vote for #145 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants