Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lines in bookmark explorer configurable via format string #145

Closed
mbenkmann opened this issue Aug 17, 2018 · 3 comments
Closed

Make lines in bookmark explorer configurable via format string #145

mbenkmann opened this issue Aug 17, 2018 · 3 comments
Assignees
Labels
enhancement side bar sponsor wanted Depends on sponsorship (PayPal / Patreon)

Comments

@mbenkmann
Copy link

Different people use bookmarks differently and will want to see different things in the bookmark explorer. I for instance do not care about column (I see bookmarks as a per-line thing) and little about the line number. But I would like to see at least part of the code at the line.

In order to please everyone I suggest to implement a format string similar to printf. E.g.

%L (Ln %l, Col %c)

would correspond to the current display (%L = label, %l line number, %c column number).

%04l: % 20C %L

would print the line number, 0-padded to at least width 4, followed by the code at the bookmark label padded with " " (note the " " between % and 20) or truncated as appropriate to 20 characters, followed by the label.

@alefragnani
Copy link
Owner

Hi @mbenkmann ,

Thanks for your suggestion! I agree that different people uses things differently, but instead of creating such complexity, just for the line preview, I prefer #143, which is much simpler. It handles two kind of users, those that want to see the information (using the same pattern from the statusbar), and those that don't want to see the information.

I hope you could fit in one of these two users 😄

@mbenkmann
Copy link
Author

#143 only requests being able to remove line and column. I don't really care about that. What is an absolute must-have for me is an excerpt of the code on the line the bookmark is on. One of my typical applications would be to set a bookmark "TODO test this". With or without line numbers, these bookmarks are pretty worthless if I'm not able to see some code context in the explorer.

@alefragnani alefragnani added good first issue Good for newcomers and removed duplicate labels Oct 31, 2018
@alefragnani alefragnani added the sponsor wanted Depends on sponsorship (PayPal / Patreon) label Nov 21, 2018
@alefragnani alefragnani self-assigned this Mar 23, 2019
@alefragnani alefragnani removed the good first issue Good for newcomers label Jul 12, 2020
@alefragnani
Copy link
Owner

I'm closing this feature request because it didn’t receive enough upvotes from the community. Still a big Thank You to you for taking the time to create this issue!

Thanks for your understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement side bar sponsor wanted Depends on sponsorship (PayPal / Patreon)
Projects
None yet
Development

No branches or pull requests

2 participants