Allow parsing of non-root productions #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccolljr
force-pushed
the
feat/parse-subprod
branch
from
657affe to
2227472
Compare
mccolljr
changed the title
|
@alecthomas wanted to solicit initial feedback before I finish up this PR using this appraoch |
mccolljr
commented
Jun 15, 2022
|
Looks pretty reasonable to me, thanks! |
alecthomas
approved these changes
Jun 27, 2022
|
Thanks! |
|
I just merged 1261c4d which makes the parser itself generic. As part of that I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a work in progress, but this PR will allow parsing non-root productions using a parser. This can be useful when implementing
Parseableor usingParseTypeWith.