-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore missing tsconfig #97
Conversation
src/types.ts
Outdated
@@ -38,6 +38,12 @@ export interface PluginOptions { | |||
* necessary. | |||
*/ | |||
parseNative?: boolean | |||
/** | |||
* Enable use of `tsconfck.resolveWithEmptyIfConfigNotFound`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems odd to mention an implementation detail in the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I'd rather copy the docs in tsconfck instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback to get this mergeable:
- remove
silent
option and setresolveWithEmptyIfConfigNotFound
to true - add a
debug("tsconfig not found: %s", project)
call before the return on line 96
Once that's done, I will release as a minor, since I don't think anyone is relying on the current behavior.
Thanks for the update @aleclarson |
This fixes #96