Adding get_constructors() #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-kr
reviewed
Oct 6, 2022
Previous link only returned about 30 constructors. New link returns all 211 teams in a single JSON file.
alec-kr
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
get_constructors()function, that takes year as an optional parameter, and returns a DataFrame of participating constructors in that year, and their nationality. If the year is not provided, return all constructors in F1 history.Related Issue(s)
Fixes #40
User-facing Changes
Users are now able to get a list of constructors by calling additional function from F1PyStats package.
Screenshots (If necessary)