Added Sprint Races #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job. I will test the code later in the day to ensure everything works fine. |
|
Great work on submitting neat and functional code. |
alec-kr
requested changes
Oct 6, 2022
There was a problem hiding this comment.
I'd like to recommend one small change though. The data you are returning in the function is missing some of the columns returned by the API, such as:
- Number
- Laps
- Grid
- Time
- Points
We should have this data returned in your function since users may need these attributes when performing any data analysis tasks with our package.
|
Okay adding them |
alec-kr
requested changes
Oct 6, 2022
alec-kr
reviewed
Oct 6, 2022
alec-kr
approved these changes
Oct 6, 2022
alec-kr
added
hacktoberfest-accepted
|
Thanks man. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added feature for getting the sprint qualifying results by adding sprint_results method.
Related Issue(s)
Fixes #52
User-facing Changes
Screenshots (If necessary)