Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logic to get driver numbers before 2014 #55

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

alec-kr
Copy link
Owner

@alec-kr alec-kr commented Oct 6, 2022

Description

I have removed the conditional check which replaced all driver numbers with None before 2014. The code now checks if a driver has a number, despite the year.

Related Issue(s)

Fixes #54 by changing the logic used to get driver numbers

User-facing Changes

Users can now view any permanent driver numbers before 2014.

Screenshots (If necessary)

Screenshot from 2022-10-05 19-59-59

@alec-kr alec-kr merged commit 1c05f28 into main Oct 6, 2022
@alec-kr alec-kr added the hacktoberfest-accepted Hacktoberfest PR has been accepted label Oct 6, 2022
@alec-kr alec-kr deleted the fix-numbers branch October 8, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest PR has been accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix None data for driver numbers
1 participant