Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Add an updated flag to backup details #1813

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Conversation

vkamra
Copy link
Contributor

@vkamra vkamra commented Dec 14, 2022

Description

Adds a flag in backup details that indicates whether the item in that backup is new/updated.

Currently always set to true but once we implement #1800 - we will set this to false for existing items from
base snapshots.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@vkamra vkamra temporarily deployed to Testing December 14, 2022 20:26 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 14, 2022 20:27 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 14, 2022 20:27 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 14, 2022 20:27 — with GitHub Actions Inactive
@vkamra
Copy link
Contributor Author

vkamra commented Dec 14, 2022

Introducing this as a placeholder so we can build tooling around the schema change.

Follow ups - we need to set this correctly when #1800 is implemented. Also need to look into what we do for kopia-assisted incrementals.

@vkamra vkamra temporarily deployed to Testing December 15, 2022 01:00 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 15, 2022 01:00 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 15, 2022 01:01 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 15, 2022 01:01 — with GitHub Actions Inactive
@vkamra vkamra temporarily deployed to Testing December 15, 2022 01:01 — with GitHub Actions Inactive
Copy link
Contributor

@rajatkateja rajatkateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 15, 2022

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 01:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 01:39 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 01:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 01:39 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Dec 15, 2022
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 15, 2022

PR failed to merge with reason: some CI status(es) failed.
Failed CI(s): Test-Suite-Trusted

@vkamra vkamra removed the blocked Upstream item prevents completion label Dec 15, 2022
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Dec 15, 2022
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 15, 2022

PR failed to merge with reason: some CI status(es) failed.
Failed CI(s): Test-Suite-Trusted

@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 03:58 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 03:58 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 03:58 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 03:58 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 15, 2022 03:58 Inactive
@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Dec 15, 2022
@aviator-app aviator-app bot merged commit debe74a into main Dec 15, 2022
@aviator-app aviator-app bot deleted the add_item_status_to_details branch December 15, 2022 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants