Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(licenses): Add CI job when cargo.toml or lock file changes #426

Merged
merged 1 commit into from
Sep 27, 2023
Merged

chore(licenses): Add CI job when cargo.toml or lock file changes #426

merged 1 commit into from
Sep 27, 2023

Conversation

0xfourzerofour
Copy link
Collaborator

Proposed Changes

  • Add cargo deny and add licenses that are acceptable
  • Run Cargo Deny in CI when cargo.toml or cargo.lock changes

dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets wait on legal until we ✅

dancoombs
dancoombs reviewed Sep 27, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
dancoombs
dancoombs approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@0xfourzerofour 0xfourzerofour merged commit 964c88b into main Sep 27, 2023
5 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/cargo-deny branch September 27, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xfourzerofour @dancoombs