Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local account signers were not correctly handling hex inputs #42

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

moldy530
Copy link
Collaborator

There was a bug in the hd-account and private key signer. it was incorrectly handling hex inputs, this addresses that bug.

I also merged the implementations for private-key signer and hd-account signer into one (and marked the old impls as deprecated to avoid breaking peoples stuff for now)

@moldy530
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@moldy530
Copy link
Collaborator Author

Test runs below. The one test that failed failed because a tx was still in the mempool. We'll fix this when we split integration tests and unit tests out

image

@moldy530 moldy530 requested a review from a team June 29, 2023 21:46
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests in this file were moved to local-account.test.ts

@moldy530 moldy530 merged commit 9d56a5b into main Jun 30, 2023
@moldy530 moldy530 deleted the moldy/fix-signers branch June 30, 2023 17:17
rthomare pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants