replace doc footer #384
Merged
replace doc footer #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
orbeckst
commented
Jul 28, 2024
•
orbeckst
commented
- fix [JOSS] inconsistent author list between docs and AUTHORS #383
- replaced explicit (incomplete) author list in doc footer with The alchemlyb development team and a link to AUTHORS
- added @xiki-tempula to the top of AUTHORS (which brings the author file in line with the author list and acknowledgements of the JOSS paper PR JOSS paper #328 )
- fix #383 - replaced explicit (incomplete) author list in doc footer with The alchemlyb development team and a link to AUTHORS - automatically insert the current year into copyright - Needed to hack the RTD theme to avoid the URL escape on the copyright variable by including a _templates/footer.html template.
The AUTHORS file should show at the top that @xiki-tempula is playing an important role for alchemlyb, in line with the acknowledgements section of the JOSS paper.
|
note: merge as individual commits (don't squash) to keep any changes to AUTHORS explicit. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 28 28
Lines 1895 1895
Branches 407 407
=======================================
Hits 1873 1873
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
xiki-tempula
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.