Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueError will be raised if concatenated amber output file has been ingested #326

Merged
merged 4 commits into from
Jun 22, 2023
Merged

ValueError will be raised if concatenated amber output file has been ingested #326

merged 4 commits into from
Jun 22, 2023

Conversation

xiki-tempula
Copy link
Collaborator

Fix #315

@xiki-tempula xiki-tempula linked an issue Jun 11, 2023 that may be closed by this pull request
Behaviour of amber parser on file with duplicated time #315
Closed
@codecov
Copy link

codecov bot commented Jun 11, 2023 •
edited
Loading

Codecov Report

Merging #326 (254f8bb) into master (1ff15fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          27       27           
  Lines        1775     1778    +3     
  Branches      389      391    +2     
=======================================
+ Hits         1753     1756    +3     
  Misses          2        2           
  Partials       20       20
Impacted Files Coverage Δ
src/alchemlyb/parsing/amber.py 99.16% <100.00%> (+0.01%) ⬆️

@xiki-tempula
Copy link
Collaborator Author

@DrDomenicoMarson Do you mind have a review of this PR as well, please? Thank you.

DrDomenicoMarson
DrDomenicoMarson approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@DrDomenicoMarson DrDomenicoMarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to me, thank you!

@xiki-tempula
Copy link
Collaborator Author

@orbeckst Sorry for rushing you. I wonder if it is possible to have a review of this PR? My plan is to merge this PR test a bit and then do the release next weekend.

@xiki-tempula
Copy link
Collaborator Author

Merge this as it has been approved by @DrDomenicoMarson and I kind of need to make a release for the company quarterly release.

@xiki-tempula xiki-tempula merged commit 3dae72a into master Jun 22, 2023
@xiki-tempula xiki-tempula deleted the 315-behaviour-of-amber-parser-on-file-with-duplicated-time branch June 22, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDomenicoMarson DrDomenicoMarson DrDomenicoMarson approved these changes

@orbeckst orbeckst Awaiting requested review from orbeckst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behaviour of amber parser on file with duplicated time
2 participants
@xiki-tempula @DrDomenicoMarson