Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #318 #319

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix #318 #319

merged 2 commits into from
Jun 1, 2023

Conversation

xiki-tempula
Copy link
Collaborator

Fix #318

@xiki-tempula xiki-tempula linked an issue Jun 1, 2023 that may be closed by this pull request
alchemlyb.visualisation.plot_convergence cannot handel the case where the final error is NaN #318
Closed
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #319 (eaa5a4d) into master (4e590cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          26       26           
  Lines        1754     1755    +1     
  Branches      382      383    +1     
=======================================
+ Hits         1732     1733    +1     
  Misses          2        2           
  Partials       20       20
Impacted Files Coverage Δ
src/alchemlyb/visualisation/convergence.py 100.00% <100.00%> (ø)

@xiki-tempula xiki-tempula requested a review from orbeckst June 1, 2023 18:05
orbeckst
orbeckst approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@orbeckst orbeckst self-assigned this Jun 1, 2023
@orbeckst orbeckst merged commit 064c4fe into master Jun 1, 2023
@orbeckst orbeckst deleted the 318-alchemlybvisualisationplot_convergence-cannot-handel-the-case-where-the-final-error-is-nan branch June 1, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alchemlyb.visualisation.plot_convergence cannot handel the case where the final error is NaN
2 participants
@xiki-tempula @orbeckst