Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Exception when no file has been matched in ABFE workflow #289

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

xiki-tempula
Copy link
Collaborator

Related to alchemistry/flamel#24. I noticed that when no file has been matched by the directory, prefix and suffix, no useful error message is being displayed. This PR should fix this issue.

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #289 (2fc4b34) into master (8e9c317) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          26       26           
  Lines        1774     1777    +3     
  Branches      381      382    +1     
=======================================
+ Hits         1751     1754    +3     
  Misses          3        3           
  Partials       20       20           
Impacted Files Coverage Δ
src/alchemlyb/workflows/abfe.py 99.66% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiki-tempula xiki-tempula marked this pull request as ready for review December 10, 2022 15:05
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensible fix, lgtm

@orbeckst orbeckst added this to the 2.0.0 milestone Dec 12, 2022
@orbeckst orbeckst merged commit 3bbbef2 into alchemistry:master Dec 12, 2022
@xiki-tempula xiki-tempula deleted the feat_filelist branch December 12, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants