Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class name for PHP7 compatibility #1

Closed
wants to merge 1 commit into from
Closed

Fix class name for PHP7 compatibility #1

wants to merge 1 commit into from

Conversation

yobrx
Copy link

@yobrx yobrx commented Apr 13, 2016

Hello,

I renamed the class String, Float, Int and Bool to be compatible with PHP7 (reserved keywords)

There is no code changes to be expected if you already use

/** @MongoDB\Field(type="string") */

instead of

/** @MongoDB\String */

in the annotations of an entity.

Thanks,

Yoann

@alcaeus
Copy link
Owner

alcaeus commented Apr 13, 2016

Thanks for the PR. It seems you've created this against my fork instead of the original at doctrine/mongodb-odm. Regardless, this was adressed in doctrine#1205 (which does not import the string, bool, int and float annotation classes in PHP 7) and doctrine#1318 (which deprecates all type annotations in favor of @Field(type=...).

@alcaeus alcaeus closed this Apr 13, 2016
@yobrx
Copy link
Author

yobrx commented Apr 13, 2016

Oups, sorry for that.

I well use the original repository but I had the problem in classes String, Int, Float and Bool, used by annotations.
I did some research and I came on your repository, thinking he had solved the problem. But the problem was well annotations... :s

Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants