Remove usage of addCleanup #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! I've tagged the PR as "not-ready" since I'm not sure you want me to merge it yet, not implying it's not ready. Feel free to remove the label when you want me to merge it. Appveyor failed but it looks like it has been broken for a long time so don't worry about it |
|
Well. For me that's ready, but there is no unit test at all (I still don't understand anything about However I'm surprised that the travis check (which passed) does not appears in the list here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addCleanupis deprecated in conduit 1.3.0 as detailled in #14This commit is preliminary work to add support for conduit 1.3.0.