Test for union type using a concrete instance of Union and scope union() template output #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we performed tests against Union symbol itself to check for inheritance. This relied on an implementation detail where an instance of a generic in the AST uses the same symbol as the generic type. The PR nim-lang/Nim#22642 changed this implementation detail. So now, we have to account for both cases of new and old compilers by also testing against a pre-defined instance. Fixes #51
In generic object context, the bare `type TImpl = T` statement might be evaluated multiple times after gensym. This causes `TImpl`gensymN` to be redefined multiple times, breaking compilation. Adding a block scope seems to solve the problem.
alaviss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fix for #51 and a generic issue that was not reported