Make number of retries user configurable #174
Labels
Milestone
Comments
JonnyJD
changed the title
iTaybb
added a commit
to iTaybb/python-musicbrainzngs
that referenced
this issue
May 10, 2017
…). Underscored so people only use if they know what they're doing. Solved issues alastair#174 and alastair#218. Signed-off-by: Itay Brandes <[email protected]>
|
Fixed in #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we retry if a request fails with a transient error state. There are some cases where people might want to fail immediately (e.g. if time is an issue and there is something to fall back on - the acousticbrainz website is an example). We should move this parameter value to something configurable. Perhaps as a
_retriesunderscore value for people to only use if they know what they're doing.Related to this is that we might want to set a custom socket timeout. People can do this currently by setting the timeout in the socket class before using the api, but we could make it part of our api too.
The text was updated successfully, but these errors were encountered: