Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL initialization - SSL_library_init is deprecated #737

Closed
21stcaveman opened this issue Sep 8, 2022 · 0 comments · Fixed by #753
Closed

OpenSSL initialization - SSL_library_init is deprecated #737

21stcaveman opened this issue Sep 8, 2022 · 0 comments · Fixed by #753

Comments

@21stcaveman
Copy link

While working on the omrabbitmq module for rsyslog, I found out that unless I stop openssl init by "amqp_set_initialize_ssl_library", it will crash the whole process (presumably because openssl is already initialized in the process).

Looking at how rabbitmq-c initializes the OpenSSL, I can see it uses both "OPENSSL_init_ssl" and "SSL_library_init" (see 'setup_openssl' in here)
Reading the docs, "SSL_library_init" has been deprecated since OpenSSL 1.1.0

Reporting this, so the OpenSSL init code can be modified to accommodate for the new versions of OpenSSL.
@21stcaveman 21stcaveman mentioned this issue Sep 8, 2022
Merged
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
Remove obsoleted OpenSSL init code
aa1a834 
Starting with OpenSSL v1.1.0, library init/uninit is automatically
handled by the library. This removes unnecessary code from rabbitmq-c
and marks the initialization functions as deprecated.

Fixed: #737

Signed-off-by: GitHub <[email protected]>
@alanxz alanxz mentioned this issue Feb 2, 2023
Merged
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
Remove obsoleted OpenSSL init code
7c81200 
Starting with OpenSSL v1.1.0, library init/uninit is automatically
handled by the library. This removes unnecessary code from rabbitmq-c
and marks the initialization functions as deprecated.

Fixed: #737

Signed-off-by: GitHub <[email protected]>
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
Remove obsoleted OpenSSL init code
01e8589 
Starting with OpenSSL v1.1.0, library init/uninit is automatically
handled by the library. This removes unnecessary code from rabbitmq-c
and marks the initialization functions as deprecated.

Fixed: #737

Signed-off-by: GitHub <[email protected]>
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
Remove obsoleted OpenSSL init code
c161b65 
Starting with OpenSSL v1.1.0, library init/uninit is automatically
handled by the library. This removes unnecessary code from rabbitmq-c
and marks the initialization functions as deprecated.

Fixed: #737

Signed-off-by: GitHub <[email protected]>
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
Remove obsoleted OpenSSL init code
320a8f3 
Starting with OpenSSL v1.1.0, library init/uninit is automatically
handled by the library. This removes unnecessary code from rabbitmq-c
and marks the initialization functions as deprecated.

Fixed: #737

Signed-off-by: GitHub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove obsoleted OpenSSL init code alanxz/rabbitmq-c
1 participant
@21stcaveman