Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian build stopped working after July 21st 2020 #265

Closed
winfij opened this issue Aug 3, 2020 · 1 comment · Fixed by #267
Closed

Debian build stopped working after July 21st 2020 #265

winfij opened this issue Aug 3, 2020 · 1 comment · Fixed by #267

Comments

@winfij
Copy link

winfij commented Aug 3, 2020

Up until recently we were able to checkout the code on Debian and just run cmake/make to build.
However in commit 47f4c79 which was nominally for "API docs polishing" in the CMakeLists.txt file there was an additional change removing the line:

include(GNUInstallDirs)

which means the default install dirs are no longer defined.
Given the doxygen changes just before that line and the lack of any mention in the commit, I'm assuming the deletion of that line was accidental.

Indeed, if I reinstate that line, the simple cmake on Debian starts working for us again.

Would it be possible to get that line reinstated in the repo, or the build instructions updated?
alanxz added a commit that referenced this issue Aug 3, 2020
@alanxz
build: restore GNUInstallDirs include (#265, #266)
3d70b25 
Include was mistakenly removed due to bad merge, this restores that.

Fixed: #265
Fixed: #266
@alanxz alanxz mentioned this issue Aug 3, 2020
Merged
@alanxz
Copy link
Owner

alanxz commented Aug 3, 2020

Good catch, #267 is out to fix this.

@alanxz alanxz mentioned this issue Aug 3, 2020
Closed
alanxz added a commit that referenced this issue Aug 3, 2020
@alanxz
build: restore GNUInstallDirs include (#265, #266)
427139e 
Include was mistakenly removed due to bad merge, this restores that.

Fixed: #265
Fixed: #266
woshilapin pushed a commit to hove-io/SimpleAmqpClient that referenced this issue Sep 9, 2022
@alanxz @woshilapin
build: restore GNUInstallDirs include (alanxz#265, alanxz#266)
7359e3b 
Include was mistakenly removed due to bad merge, this restores that.

Fixed: alanxz#265
Fixed: alanxz#266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: restore GNUInstallDirs include (#265, #266) alanxz/SimpleAmqpClient
2 participants
@alanxz @winfij