Improve the test which validates empty files in hybrid torrents (issue #685) #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test didn't verify the underlying bencoded dictionary contained no 'pieces root', but it did verify that no pieces root was loaded for zero length files. This fixes one potential source of incompatibility when working with zero length files.
They were out of sync when empty files were in the torrent, however due to interesting quirks, this didn't cause the infohash or any piece hashes to be incorrect as only empty files were out-of-order. Fix this by resorting the files one more time before putting them in the torrent metadata. Also - this is only detectable by directly validating the content of the BEncodedDictionary for some reason. A validation was missing while parsing the underlying BENcodedDictionary, it was written to operate on the parsed ITorrentFile objects instead, and at that point it was all correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test didn't verify the underlying bencoded dictionary contained no 'pieces root', but it did verify that no pieces root was loaded for zero length files.
This fixes one potential source of incompatibility when working with zero length files.