Add tests for hash sharing #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmcgovern
commented
Aug 20, 2024
alanmcgovern
commented
Aug 20, 2024
src/Tests/Tests.MonoTorrent.IntegrationTests/IntegrationTests_RealPieceWriter.cs
Outdated
Show resolved
Hide resolved
alanmcgovern
commented
Aug 20, 2024
src/Tests/Tests.MonoTorrent.IntegrationTests/IntegrationTests_RealPieceWriter.cs
Outdated
Show resolved
Hide resolved
alanmcgovern
force-pushed
the
add-tests-for-hash-sharing
branch
3 times, most recently
from
7a6eee1
to
78696ea
Compare
alanmcgovern
commented
Aug 20, 2024
Comment on lines
+124
to
+125
| if (Engine.PeerId.Equals (message.PeerId)) | ||
| return false; |
There was a problem hiding this comment.
This moves the peer id check earlier, prior to raising the 'PeerConnected' event and adding the peer as an active connection. It's a little cleaner this way :)
This test validates that for both incoming and outgoing connections, both sides of the handshake correctly treat the connection as upgraded to v2 after a v1 handshake is sent. This adds tests covering commit 89874d0. I over-eagerly merged that prior to adding the test, but i also reverted the change to ensure this test failed without those changes.
alanmcgovern
force-pushed
the
add-tests-for-hash-sharing
branch
from
78696ea
to
bd94483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backfills tests for 89874d0