[core] Ratelimiters should allow requests larger than chunk size #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the ratelimiter is set to download at 15kB/sec or less, the amount of data in the ratelimit will always be less than the size of one block. In this case, we should allow the request to succeed. Once there's negative data left in the allowance, deny requests. As the ratelimiter is topped up over time, future requests will be unblocked.
alanmcgovern
commented
Jan 31, 2023
src/Tests/Tests.MonoTorrent.Client/MonoTorrent.Client.RateLimiters/RateLimiterTests.cs
Outdated
Show resolved
Hide resolved
…ters/RateLimiterTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ratelimiter is set to download at 15kB/sec or less, the amount of data in the ratelimit will always be less than the size of one block. In this case, we should allow the request to succeed.
Once there's negative data left in the allowance, deny requests. As the ratelimiter is topped up over time, future requests will be unblocked.