[core] Support ipv4 and ipv6 compact addresses #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment
PeerInfoto also support parsing IPV6 addresses. The format used to parse the compact peer notation into an actual IPAddress/Uri is still hardcoded to assume IPV4 in a few places, though that's primarily because more groundwork needs to be done to fully map IPv6 throughout dht, peer exchange, etc.Some parts of the spec are written to allow sending
ipv4andipv6formats in the same message, others use the active connection type to discriminate. i.e. if you send a udp request over ipv4 you get ipv4 peers back, if you send it over ipv6 you get ipv6 peers.It makes it a bit more complicated to support as a result.
#588