forked from scipy-conference/scipy_proceedings
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Multinterp branch, JY reviewer PR, edit main.md, add comments_figs_nbs.md #1
Open
JennEYoon
wants to merge
24
commits into
alanlujan91:multinterp
Choose a base branch
from
JennEYoon:multinterp
base: multinterp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Alan,
Thank you for the opportunity to review Multinterp paper for SciPy Conference Proceedings 2024. All of my comments are to improve readability for the general reader. Please feel free to incorporate or ignore any of my suggestions.
File edit: main.md
[[ suggestions enclosed between double brackets ]]
Add file: comments_figs_nbs.md ( suggestions on figures )
screenshots (hand markup drawings)
.\figures\
best email: [email protected]
Github acct: JennEYoon
Sincerely,
Jennifer Yoon
July 24, 2024