Fix invalid output code when eliding TS star imports #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From some manual testing, I noticed that the code: ```ts import A, * as B from "./A"; console.log(A); ``` becomes this invalid code: ```ts import A, from "./A"; console.log(A); ``` The `* as B` was being elided because it's treated as a type-only import, but in this case we need to elide the comma as well since there's no concept of "trailing commas" here. The code to do that is a little clunky, but I ended up always removing the comma and using a boolean to track whether it should be added back.
Codecov Report
@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 87.05% 87.15% +0.10%
==========================================
Files 54 54
Lines 5702 5708 +6
Branches 1343 1345 +2
==========================================
+ Hits 4964 4975 +11
+ Misses 470 466 -4
+ Partials 268 267 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark resultsBefore this PR: 345.1 thousand lines per second Measured change: 0.04% faster (0.74% slower to 0.21% faster) |
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
From some manual testing, I noticed that the code: ```ts import A, * as B from "./A"; console.log(A); ``` becomes this invalid code: ```ts import A, from "./A"; console.log(A); ``` The `* as B` was being elided because it's treated as a type-only import, but in this case we need to elide the comma as well since there's no concept of "trailing commas" here. The code to do that is a little clunky, but I ended up always removing the comma and using a boolean to track whether it should be added back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some manual testing, I noticed that the code:
becomes this invalid code:
The
* as Bwas being elided because it's treated as a type-only import, but inthis case we need to elide the comma as well since there's no concept of
"trailing commas" here. The code to do that is a little clunky, but I ended up
always removing the comma and using a boolean to track whether it should be
added back.