Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for re-exporting name after star export #704

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

alangpierce
Copy link
Owner

Follow-up adding a test for #698

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #704 (0f61718) into main (ce4dc62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          54       54           
  Lines        5767     5767           
  Branches     1313     1313           
=======================================
  Hits         4886     4886           
  Misses        597      597           
  Partials      284      284           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

Benchmark results

Before this PR: 286 thousand lines per second
After this PR: 287.9 thousand lines per second

Measured change: 0.66% faster (0.19% slower to 1.2% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 489871e into main Jun 21, 2022
@alangpierce alangpierce deleted the add-test-for-re-export-after-star-export branch June 21, 2022 23:36
1Lighty pushed a commit to Astra-mod/sucrase that referenced this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant