Disable the class fields transform when disableESTransforms is set #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disableESTransforms is specified, the class transform can almost entirely be skipped, but we still need to do some work: * TS constructor initializers (e.g. constructor params with `readonly` or `private`) need to be transformed to assignments within the constructor. * Fields marked `declare` need to be removed. Uninitialized fields not marked declare are preserved, matching the ES spec and the `useDefineForClassFields` flag in TS. For now, we still use the `getClassInfo` code path but give alternate results. In the future we can hopefully simplify that code path, and possibly change `declare` parsing so the whole line consists of type tokens that will naturally be erased.
Codecov Report
@@ Coverage Diff @@
## main #625 +/- ##
==========================================
- Coverage 82.20% 82.16% -0.05%
==========================================
Files 56 56
Lines 5874 5646 -228
Branches 1326 1330 +4
==========================================
- Hits 4829 4639 -190
+ Misses 762 724 -38
Partials 283 283
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 322.4 thousand lines per second Measured change: 0.56% faster (0.58% slower to 1.51% faster) |
alangpierce
deleted the
skip-class-transform-when-disabling-es-transforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disableESTransforms is specified, the class transform can almost entirely
be skipped, but we still need to do some work:
readonlyorprivate) need to be transformed to assignments within the constructor.declareneed to be removed. Uninitialized fields not markeddeclare are preserved, matching the ES spec and the
useDefineForClassFieldsflag in TS.
For now, we still use the
getClassInfocode path but give alternate results.In the future we can hopefully simplify that code path, and possibly change
declareparsing so the whole line consists of type tokens that will naturallybe erased.