Fix TS export elision for destructured variables #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #563 Fixes #473 The type-only export elision implemented in #433 had a false positive for destructure delcarations, since `getDeclarationInfo` only looks at top-level declarations and top-level expressions like `const {x} = ...` weren't being marked correctly. To fix, we can mark object shorthand declarations as top-level when applicable. I also refactored both relevant code paths to avoid the repeated assignment left-hand side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #563
Fixes #473
The type-only export elision implemented in #433 had a false positive for
destructure delcarations, since
getDeclarationInfoonly looks at top-leveldeclarations and top-level expressions like
const {x} = ...weren't beingmarked correctly. To fix, we can mark object shorthand declarations as top-level
when applicable. I also refactored both relevant code paths to avoid the
repeated assignment left-hand side.